feat: filter query preview #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gerardo Vázquez <[email protected]>
lauramargar
changed the title
CachedaCodes
suggested changes
Sep 20, 2023
packages/x-components/src/x-modules/queries-preview/components/query-preview-button.vue
Outdated
Show resolved
Hide resolved
CachedaCodes
suggested changes
Sep 20, 2023
| */ | ||
| const moduleName = 'facets'; | ||
|
|
||
| const wireCommitWithoutPayload = namespacedWireCommitWithoutPayload(moduleName); |
There was a problem hiding this comment.
Document this and put it below the wireCommit.
CachedaCodes
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
It would be great if we could add filters & extra params to the search request, now extra params are developed, so we also have to add filters. These params could help to narrow the results, that could be very interesting for some customers.
In this PR, I have merged the branch of filter carrousels of brand recommendations. So we should have the complete functionality of filter query previews.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Here we can test if brand recommendation carrousels are filtered and if when we click the query preview button, filters are applied.